Skip to content

Breaking: Bump to ember-cli 3.24#95

Merged
josemarluedke merged 9 commits intojosemarluedke:masterfrom
concordnow:v5
Sep 28, 2021
Merged

Breaking: Bump to ember-cli 3.24#95
josemarluedke merged 9 commits intojosemarluedke:masterfrom
concordnow:v5

Conversation

@ctjhoa
Copy link
Contributor

@ctjhoa ctjhoa commented Sep 20, 2021

Prepare v5.0.0, includes:

  • Bump to ember 3.24
  • Octane migration
  • Clean initializers
  • Remove pre Ember module api deps
  • Move to github actions (Results can be seen here)

@josemarluedke josemarluedke merged commit f8f263b into josemarluedke:master Sep 28, 2021
@josemarluedke
Copy link
Owner

@ctjhoa Thank you for working on this! 🎉 🎉 🎉

@josemarluedke josemarluedke added the dependencies Pull requests that update a dependency file label Sep 28, 2021
@GabrielCousin
Copy link
Contributor

Hey!
Thanks for the amazing work on that.
Are you guys confident in releasing this soon? I mean tagging it of course 😊

@ctjhoa
Copy link
Contributor Author

ctjhoa commented Oct 21, 2021

@GabrielCousin This introduce breaking changes so it will be a major version.
I'd like to fix this before releasing it because it will also affect how the segment script is loaded.
I don't know @josemarluedke opinion on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants